[cupertino_http] Regenerate bindings with ffigen 21 - #1975
Open
stwime wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
package:cupertino_http
Requests that were still in flight when their isolate shut down could abort the process from a URLSession delegate callback, because the generated listener blocks invoked the Dart callback directly. ffigen 21.0.0 routes those callbacks through `DOBJC_invokeListenerPortBlock`, so bump `ffigen` and the `objective_c` runtime it needs, and regenerate.
stwime
force-pushed
the
cupertino-http-ffigen-21
branch
from
August 14, 2026 07:19
37a3ff7 to
c620511
Compare
dangthaison91
pushed a commit
to dangthaison91/http-dart
that referenced
this pull request
Aug 15, 2026
Generated Objective-C listener blocks invoked Dart FFI callbacks directly. If a URLSession delegate callback arrived after the owning isolate shut down, the Dart VM aborted with "Callback invoked after it has been deleted." Bump objective_c to 9.5.0 and ffigen to 21.0.0, then regenerate the bindings so listener blocks dispatch through DOBJC_invokeListenerPortBlock, which safely drops callbacks whose receive port no longer exists. Add the upstream isolate-shutdown regression test from dart-lang#1975. Refs: dart-lang#1975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests that were still in flight when their isolate shut down could abort the process from a URLSession delegate callback, because the generated listener blocks invoked the Dart callback directly.
ffigen 21.0.0 routes those callbacks through
DOBJC_invokeListenerPortBlock, so bumpedffigenand theobjective_cruntime it needs, and regenerated.Fixes #1894
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.